Repository navigation
Fix pylint used-before-assignment errors - #2554
Merged
sawenzel merged 1 commit intoNov 18, 2026
Merged
Conversation
This fixes the four files that fail the pylint check in CI. - mcprodinfo_harvester.py used Col, IntRate and OrbitsPerTF unset when the workflow has no meta block; they now default to None. - makeStarlightConfig.py and makeUpcgenConfig.py pick the beam Z and A from a lookup table instead of a chain of ifs. - o2dpg_sim_workflow.py uses else instead of elif tf > 1 for the HepMC event skip.
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
sawenzel
enabled auto-merge (rebase)
November 18, 2026 09:10
sawenzel
disabled auto-merge
November 18, 2026 09:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the ten errors that make the pylint check in CI fail.
mcprodinfo_harvester.py:Col,IntRateandOrbitsPerTFwere unset when the workflow has nometablock; they now default toNone.makeStarlightConfig.py,makeUpcgenConfig.py: the beam Z and A come from a lookup table instead of a chain of ifs. The generated ini files are byte-identical for all collision systems.o2dpg_sim_workflow.py:elseinstead ofelif tf > 1for the HepMC event skip; no change in behaviour.